java - converter class test driven -

-

i have class, should convert data 1 format (database librarytype). looks like:

public librarytype converttolibrary(database db, parameters params) {      preconditions.checknotnull(db," missing database conversion");     preconditions.checknotnull(params, "missing parameters conversion");      librarytype lib = basicfactory.createlibrarytype();     lib.setname(db.getname());     componenttype type = convertstructure(db.getstructure(),params);      if (type != componenttype.empty) {         lib.addcomponent(type);     }      return lib; }  componenttype convertstructure(structure s, parameters params) {     if (!params.isstructureallowed(s)) return componenttype.empty;     componenttype comp = basicfactory.createcomponenttype();           comp.setname(s.getname());    return comp; }

i have 2 problems concept.

  1. the method convertstructure should private, because not neccessary call outside, testing purposes defined package-wide, not nice

  2. the parameters (params) passed sub-method. use class field insert during constructor, because of using guice di-framework, cannot pass data constructor. parameters change during runtime. need pass method parameter. set class field in converttolibrary method, cannot test method convertstructure.

did run design problem or there useful workarounds? make sense split different classes, not sound me, because still feel 1 responsibility (srp) in class (converting data)?

thanks help

answer question 1 (and perhaps question 2):

if feel need write test convertstructure(), think sign should in own class. test should not test things smaller single responsibility (imo).

that said, i'm not sure need test convertstructure() in isolation. isn't testing convertlibrary() enough? or perhaps larger unit?

opinion: have preference of testing outside in, testing @ high level start , testing smaller parts when need to. start testing behaviour, seen user of system, , test implementation details when needed. not agrees me though.


Comments

Post a Comment

Popular posts from this blog

html5 - What is breaking my page when printing? -

-
Image
i have questioner , don't know why when printing it's creating break before first question. live demo (link) i able resolve issue removing fieldset container had wrapped in.. having fieldset element causing of fields grouped together, , since not fit on first page, being pushed second page. removing fieldset element, able firefox print first 2 questions on page 1 identically chrome. it seems not new problem firefox , fieldset not playing nice found old bugzilla ticket 2008 has persisted , still being commented on in 2014 (link) if retaining fieldset important, found solution else came here (link) <script type='text/javascript'> $(window).bind('beforeprint', function(){ $('fieldset').each( function(item) { $(this).replacewith($('<div class="fieldset">' + this.innerhtml + '</div>')); } ) }); $(window).bind(
Read more

c# - must be a non-abstract type with a public parameterless constructor in redis -

-
when save object, got below error must non-abstract type public parameterless constructor in order use parameter 't' in generic type or method 'servicestack.redis.redisclient.store<t>(t) redisclass.getinstnace().store(msg); // error here redisclass.getinstnace().save(); as third party's class, can not edit how save object? could create wrapper around third party object call constructor, store wrapper? e.g. public class mywrapper { public thirdpartyobject thirdpartyinstance { get; set; } public mywrapper() { thirdpartyinstance = new thirdpartyobject("constructors"); } }
Read more

ajax - PHP/JSON Login script (Twitter style) not setting sessions -

-
i'm having trouble getting twitter style login work properly, reason gets stuck at session_register("useremail"); session_register("userpass"); and doesn't redirect after it. if enter wrong account data, works , appropriate error message pops up. this full code: <?php if(empty($_post['email']) || empty($_post['password'])) { die(msg(0,"all fields required")); } if(!(preg_match("/^[\.a-z0-9_\-\+]+[@][a-z0-9_\-]+([.][a-z0-9_\-]+)+[a-z]{1,4}$/", $_post['email']))) die(msg(0,"you haven't provided valid e-mail")); $host="localhost"; $username="root"; $password="x"; $db_name="x"; $tbl_name="x"; mysql_connect("$host", "$username", "$password")or die("cannot connect"); mysql_select_db("$db_name")or die("cannot select db"); $useremail=$_post['email']; $userpass=
Read more